Fixed palette index for zeroed color in FASTOCTREE quantize #5869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
quantize_palette
branch
from
456aab1 to
695dd5f
Compare
radarhere
changed the title
radarhere
force-pushed
the
quantize_palette
branch
from
695dd5f to
fdec387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #4640
When using
quantize(), most methods place the colors into the palette and then fill up the remaining colors with "\x00\x00\x00"You can see that the first part of the palette is the
(255, 0, 0).So what if the color in the image was actually
(0, 0, 0)?Still working as expected. However, for
Image.FASTOCTREE,it actually uses the last palette entry rather than the first. So the
ImagePalette.colorsends up being wrong.>>> quantized_im.palette.colors {(0, 0, 0): 0}This PR fixes this by just setting the palette colors in decreasing order instead of increasing, so that the operation to set (0, 0, 0) to 0 now comes after the operation to set (0, 0, 0) to 255.