Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Nov 30, 2021

Changes proposed in this pull request:

@nulano
Copy link
Contributor

nulano commented Nov 30, 2021

Good idea. I would suggest changing the condition in test-windows.yml for building wheels from if: "github.event_name == 'push'" to if: "github.event_name != 'pull_request'" as well as the related conditions throughout the workflow - this would enable anyone to trigger a Windows build and download the wheels for any specific revision in their fork without the GPL imagequant dependency - that seems to me more useful than manually triggering a build with imagequant enabled but not generating wheels.

@hugovk
Copy link
Member Author

hugovk commented Dec 1, 2021

Updated, how does 915d014 look?

Copy link
Contributor

@nulano nulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radarhere radarhere merged commit c5d9223 into python-pillow:main Dec 5, 2021
@hugovk hugovk deleted the workflow_dispatch branch December 5, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants