Skip to content

Conversation

@radarhere
Copy link
Member

#4333 prevented polygon pixels from being drawn more than once, so that the transparencies of pixels would not be combined to create an unintended result.

However, #5700 reported that this results in a speed decrease.

This PR switches back to the earlier, faster method of drawing pixels repeatedly - when drawing without transparency. This means that the slower method to avoid the transparency problem is not used when it does not need to be used.

@ntninja
Copy link

ntninja commented Nov 15, 2021

Thank you! I will test this shortly and report back!

@ntninja
Copy link

ntninja commented Nov 15, 2021

I can confirm this works in our setup, thank you!

@hugovk
Copy link
Member

hugovk commented Nov 15, 2021

@ntninja Thank you for testing!

@radarhere Thank you for the PR! Can we add tests to cover the (hasAlpha == 1) branch?

@radarhere
Copy link
Member Author

Ah, I had presumed that the test from #4333 would still cover this situation, but #4523 changed ellipses so that they are no longer polygons.

Ok, I've added a test.

@hugovk
Copy link
Member

hugovk commented Nov 16, 2021

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants