Added specific error messages when ink has incorrect number of bands #5504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5503
The issue requests that the error if
inkhas an incorrect number of bands be clearer than the default "TypeError: function takes exactly 1 argument (3 given)".This PR adds error messages similar to
Pillow/src/_imaging.c
Line 519 in 16b9cad
not just for 1 band images as mentioned in the issue, but also for other similar situations in the same C function.
While I'm here, I'm also replacing
Pillow/src/_imaging.c
Line 501 in 16b9cad
with
PyTuple_Check(color) && PyTuple_GET_SIZE(color) == 1, since we have already performed the error checking withPyTuple_Check.