Skip to content

Conversation

@xtsm
Copy link
Contributor

@xtsm xtsm commented May 2, 2021

Fixes #5432 .

@radarhere radarhere changed the title Remove spikes when drawing thin pies Remove spikes when drawing acute pieslices May 5, 2021
@radarhere radarhere changed the title Remove spikes when drawing acute pieslices Remove spikes when drawing thin pieslices May 5, 2021
Comment on lines +1362 to +1363
spike_clipper->a = (xl + xr) / 2.0;
spike_clipper->b = (yl + yr) / 2.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my explanation of what is happening here.
This is taking the average of the two points on the outside of the circle. Going through the center of the circle as well, that gives us a line down the middle of the pieslice.
Then by swapping x and y (normally y would be with a), and multiplying one of them by -1, it gives us a perpendicular line. Because the line also goes through the center of the circle, that cuts off the spike.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's one way to put it
line equation Ax+By+C=0 can be also written as rn + C = 0, r(x, y), n(A, B) - i.e. n(A, B) is a normal vector for line

@radarhere radarhere merged commit 78406ed into python-pillow:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pieslice draws very thin sectors incorrectly

2 participants