Improved getxmp() #5455
Merged
Improved getxmp() #5455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My feature request, and by extension this PR, breaks API (it introduces intermediate dictionaries on the path). I personally think this is fine as Pillow v8.2 introduced many breaking changes to Exif reading anyway, and is fairly recent. As I said in #5454, exiftool already produces Exif that the current API can't support, so maybe it's worth the breaking change. |
radarhere
changed the title
Closed
23 tasks
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Jun 30, 2021
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Jun 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5454 by correcting how JPEG getxmp() descends into XML
Resolves #5531 by adding
getxmp()methods for PNG and TIFF