Valgrind fixes #5397
Merged
Valgrind fixes #5397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR works and valgrind passes on libjpeg-turbo 1.5.2 (ubuntu 18.04), but it's failing on libjpeg-turbo 2.0.3 (ubuntu-20.04). |
Member
Author
|
It also passes with manylinux-wheels with libjpeg 9.0, which is what we're shipping. Do we actually ever test with the versions of the libraries we're shipping, other than when we actually make the wheels? |
wiredfool
commented
Apr 9, 2021
| @@ -1,7 +1,5 @@ | |||
| from io import BytesIO | |||
|
|
|||
| import pytest | |||
Member
Author
There was a problem hiding this comment.
It's probably not worth fixing lint until we pass the: "Does it work" and "Is it a good idea" tests.
wiredfool
force-pushed
the
valgrind_fixes
branch
from
b538647 to
a3a69c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of the valgrind XFAILs that we've had, including fixing the non-xfailed test_fuzzers.