-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix pytest valgrind warnings #5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! Confirmed fixed in a dummy commit: https://github.com/hugovk/Pillow/runs/2244123927?check_suite_focus=true |
|
Although it does detect a bunch of errors. Should these also fail the CI? |
|
There are a few XFAILed here because they're undefined behaviour and I haven't tracked them down yet. (some of which are deep in JPEG guts). The recent addition of the fuzzer test -- which runs all the images through open/load has retriggered some of them that are xfailed (I think) but I haven't had a chance to get to them. My idea for now is to prevent additional items from making valgrind worse. Which I'm failing at a bit with the fuzzer test, but to be fair, that's increased testing, not increased code to be tested. |
Potential fix for pytest-valgrind mark not defined for non-valgrind docker tests.