Skip to content

Document and add tests for SBIX color font support #5155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 4 commits into from
Mar 8, 2021
Merged

Document and add tests for SBIX color font support #5155

hugovk merged 4 commits into from
Mar 8, 2021

Conversation

@nulano
Copy link
Contributor

@nulano nulano commented Dec 30, 2020 •
edited
Loading

In #4955 I missed that FreeType 2.5.1 added SBIX font support, this PR adds tests and corrects the documentation / 8.0.0 release notes. The font is from https://github.com/RoelN/ChromaCheck (MIT license), I couldn't find any other fonts that were under 15MB.

Also some minor formatting cleanup of the other color font tests.

FreeType release notes: https://sourceforge.net/projects/freetype/files/freetype2/2.5.1/

radarhere
radarhere reviewed Dec 30, 2020
View reviewed changes
radarhere
radarhere reviewed Dec 30, 2020
View reviewed changes
@hugovk
Copy link
Member

hugovk commented Mar 7, 2021

The font is from RoelN/ChromaCheck (MIT license), I couldn't find any other fonts that were under 15MB.

I was going to say 15 MB is too big (the sdist is currently 45 MB) and we could move it instead to https://github.com/python-pillow/pillow-depends, but chromacheck-sbix.woff is only 740B?

@hugovk hugovk added the Testing label Mar 7, 2021
@nulano
Copy link
Contributor Author

nulano commented Mar 7, 2021

The font is from RoelN/ChromaCheck (MIT license), I couldn't find any other fonts that were under 15MB.

I was going to say 15 MB is too big (the sdist is currently 45 MB) and we could move it instead to https://github.com/python-pillow/pillow-depends, but chromacheck-sbix.woff is only 740B?

I meant that all other fonts I could find were 15 MB or larger, not that this specific font is large 😄. I would have preferred to use a font more complicated than just a single rectangle, but couldn't find anything small enough.

@hugovk
Copy link
Member

hugovk commented Mar 7, 2021

Ah great! Well let's get the merge conflict resolved and this merged!

@nulano
Copy link
Contributor Author

nulano commented Mar 7, 2021

Ah great! Well let's get the merge conflict resolved and this merged!

Resolved.

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Mar 7, 2021
@nulano
Copy link
Contributor Author

nulano commented Mar 7, 2021

GitHub App like Mergify are not allowed to merge pull request where .github/workflows is changed.

Because I changed (fixed) a comment in the workflow... 😕

@hugovk hugovk merged commit 8accaf0 into python-pillow:master Mar 8, 2021
@nulano nulano mentioned this pull request Mar 14, 2021
Merged
@nulano nulano deleted the sbix branch September 18, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radarhere radarhere radarhere left review comments

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

automerge Automatically merge PRs that are ready Font Rendering Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nulano @hugovk @radarhere