Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 18, 2020

For #722.

Changes proposed in this pull request:

  • Adds some extra tests for ImagePath.Path
  • Bumps path.c coverage from 64.52% to 75.63%
  • "Pillow (PIL) examples" was handy to check some example calls

@hugovk hugovk added the Testing label Dec 18, 2020
@pytest.mark.parametrize(
"coords, expected",
[
([0, 1, 2, 3], (0.0, 1.0, 2.0, 3.0)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this line adds any coverage - but you'll probably just tell me that it's to be more systematic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, turns out this line didn't add any. The next one was to add coverage. Let's keep both to be systematic :)

@radarhere radarhere merged commit c52c3ae into python-pillow:master Dec 19, 2020
@hugovk hugovk deleted the add-path-tests branch December 19, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants