Releasing: Replace viewdoc with markdown2 and twine check #4983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewdoc
Part of RELEASING.md is
make release-test, which installsjarn.viewdocand runsviewdoc:And creates this broken
.long.description.html(renamed and zipped: long-description.html.zip)https://github.com/Jarn/jarn.viewdoc says:
But now our README is Markdown not reStructuredText (#4872).
markdown2
Viewdoc doesn't support converting MD to HTML, only RST to HTML. Instead let's use https://github.com/trentm/python-markdown2 to convert MD to HTML.
twine check
There's also,
twine check:https://twine.readthedocs.io/en/latest/#twine-check
We create the sdist after branching, tagging and pushing, so it's better to check it beforehand.
twine checkis still useful, it checks all the generated wheels too. So I've addedtwine checkbeforetwine upload, and tweaked the other steps so we move all the Windows wheels, and Mac and Linux wheels into/distand we can check them all at once.And then also upload them all at once, to make sure all wheels and uploaded at the same time, not so we have, say, sdist+Mac+Linux wheels uploaded but failing installs for Windows. (I've been waiting and doing them all at once anyway.)