Cffi pixelaccess #476
Merged
Cffi pixelaccess #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganized to remove ImagingMemoryInstance struct, only saving the three pointers that we need (image, image8, image32) and the x/ysize ints.
Make sure we clear the pyaccess object each time we reset the self.im object
wiredfool
added a commit
that referenced
this pull request
Jan 31, 2014
Cffi PixelAccess object, Uint16 support in PixelAccess
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248, #67
This is a python /cffi implementation of the PixelAccess object and assorted hooks in Image.getpixel/putpixel. It is enabled by default for pypy, not for the c-python implementations. It requires cffi to be installed at runtime, there are no build dependencies.
This branch is (knock on wood) complete and consistent with the existing c-api implementation of pixel access (assuming and including #455 the i16-pixelaccess branch patches). It appears to be fast enough, but I haven't spent a ton of time tweaking it for ultimate speed.
I've tested this on little-endian and big-endian systems -- all tests pass on both platforms. (note that I tested in Python 2.7 on ppc, not pypy. I don't think pypy has made it to ppc yet. )