Skip to content

Conversation

@megabuz
Copy link

@megabuz megabuz commented Jul 1, 2013

libtiff can work with many tiff compressions, such as deflate, adobe deflate, sgilog and others. So we can add this functionality such as group4 decoder/encoder

@aclark4life
Copy link
Member

Any risks merging this?

@megabuz
Copy link
Author

megabuz commented Jul 1, 2013

i can't find libtiff release notes, so i don't know when they add this compressions types, but i think, it is old functionality

@megabuz
Copy link
Author

megabuz commented Jul 1, 2013

Found release notes, everything ok. I don't see any risk

aclark4life added a commit that referenced this pull request Jul 1, 2013
Add several TIFF decoders and encoders
@aclark4life aclark4life merged commit fd98b0c into python-pillow:master Jul 1, 2013
@aclark4life
Copy link
Member

Thanks all

@wiredfool
Copy link
Member

The only danger I can see is that some of the full color tiff compressions can have an awful lot of data behind them, and when going from an in-memory string, it's an all at once thing. So, memory exhaustion could be an issue.

(Also, might want to check on some signed/unsigned things, I'm not sure if there will be issues if we get something that's over 2 gig uncompressed)

radarhere pushed a commit to radarhere/Pillow that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants