add spherical geometry support in compressible #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d with a simple pcolormesh plot
…o2 into compressible_geometric_term
…o2 into compressible_geometric_term
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…cosity for sphericalpolar
|
can you split this up into a few different PRs? For example:
some of the Riemann changes are similar to what I've been doing to allow us to have more solvers. |
…flux to optionally allow output conserved variable
zingale
reviewed
Aug 30, 2024
|
okay, I think this is good. There might be some changes in the future, but let's merge this and then we can play with it more. |
zingale
approved these changes
Aug 30, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses issue #203