Skip to content

switch away from setup.py to pyproject.toml #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2024
Merged

switch away from setup.py to pyproject.toml #195

merged 4 commits into from
Apr 22, 2024

Conversation

zingale
Copy link
Collaborator

@zingale zingale commented Apr 22, 2024

this is consistent with PEP 517 and 621

yut23
yut23 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@yut23 yut23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the built wheels and sdists against main and all the same files are present.

@zingale
Copy link
Collaborator Author

zingale commented Apr 22, 2024

cool. I was able to run locally without issue too.

@zingale zingale merged commit e19d5b3 into python-hydro:main Apr 22, 2024
@zingale zingale deleted the switch_from_setup.py branch April 22, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23