Skip to content

Defer annotation eval on Python 3.14 #13550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2025
Merged

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Jun 21, 2025

Fixes #13549

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 21, 2025
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, thanks

@RonnyPfannschmidt RonnyPfannschmidt added the backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch label Jun 22, 2025
@cdce8p
Copy link
Contributor Author

cdce8p commented Jun 22, 2025

Anything else left here? The test failures look unrelated to me.

@RonnyPfannschmidt
Copy link
Member

Failures are unrelated
We are responsible for merging soon

@nicoddemus
Copy link
Member

Will merge after #13548.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cdce8p!

@nicoddemus nicoddemus enabled auto-merge (squash) June 22, 2025 15:49
@nicoddemus nicoddemus merged commit 8ca783c into pytest-dev:main Jun 22, 2025
36 checks passed
Copy link

patchback bot commented Jun 22, 2025

Backport to 8.4.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.4.x/8ca783cf4a3b4007f513a7446b7069d4dac52587/pr-13550

Backported as #13553

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 22, 2025
nicoddemus pushed a commit that referenced this pull request Jun 22, 2025
Fixes #13549

(cherry picked from commit 8ca783c)

Co-authored-by: Marc Mueller <[email protected]>
@cdce8p cdce8p deleted the 314-signature branch June 22, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unresolved annotations shouldn't throw errors on Python 3.14
4 participants