ENH: Improve warning stacklevel#12014
Merged
Zac-HD merged 5 commits intopytest-dev:mainfrom Feb 23, 2024
Merged
Conversation
Contributor
Author
|
Okay added a test, rebased, and targeted |
for more information, see https://pre-commit.ci
RonnyPfannschmidt
previously requested changes
Feb 21, 2024
Member
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
lovely enhancement 👍
please add a changelog fragment for towncrier, you can use the pr id as issue id
also do you want to rebase/squash or should we
Contributor
Author
|
Stub added, feel free to squash at your end! |
Zac-HD
approved these changes
Feb 23, 2024
flying-sheep
pushed a commit
to flying-sheep/pytest
that referenced
this pull request
Apr 9, 2024
* ENH: Improve warning stacklevel * TST: Add test * TST: Ping * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * MAINT: Changelog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include documentation when adding new features.AUTHORSin alphabetical order.This is really proposal-by-PR (because the PR is pretty trivial). In MNE-Python at least it takes this warning on 8.0.1:
and puts it on the correct line needed to fix the warning
Happy to add to some test if people think this is a good idea and will work in the general case. Happy to explore if it will work in some cases (esp. if someone can point me to the right place to add a test!).
Can also rebase and re-target for
mainbut on my machine at least I get a cryptic error when I try to use latestmainwith MNE-Python so haven't done that for now.