-
Notifications
You must be signed in to change notification settings - Fork 3
CI update #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the versions of the GitHub actions and the NEP29 dependencies.
Added a summary of the changes to the log.
Moved the xarray installation with limits to the NEP29 sections.
jklenzing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the GA log for the nep29 job:
Installing collected packages: pytz, six, pyparsing, numpy, python-dateutil, packaging, pandas, xarray
Attempting uninstall: numpy
Found existing installation: numpy 1.20.0
Uninstalling numpy-1.20.0:
Successfully uninstalled numpy-1.20.0
Successfully installed numpy-1.23.4 packaging-21.3 pandas-1.5.1 pyparsing-3.0.9 python-dateutil-2.8.2 pytz-2022.5 six-1.16.0 xarray-2022.3.0
I'm not sure why it's updating numpy after installing the requested version. I have a new structure up at sami2py/sami2py#175 that fixes the issue.
Sorry about the confusion on this update. I think I was looking at the wrong part of the log before.
Removed the comma between numpy and xarray.
The uninstall isn't necessary and breaks things.
Xarray "fixed" the prior numpy issue by installing the newest numpy. Fix this by not limiting the xarray installation.
|
Ok @jklenzing what do you think? The alternative is to limit the pandas version to one that works with numpy 1.20.0 (probably 1.4.x). |
I'm happy enough with this. In January, numpy 1.21 becomes the new minimum, so it becomes moot at that point. I think we need to discuss how we proceed across pysat packages at the next meeting. At the moment, I'm leaning toward the separate requirements file like in sami2py. Probably the right way is to implement docker at some point. |
Description
Addresses #120 by updating the CI. Also addresses: https://github.com/orgs/pysat/projects/2
Type of change
How Has This Been Tested?
Must be tested on GitHub Actions.
Test Configuration:
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release