Skip to content

Conversation

@jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Dec 30, 2020

This PR updates:

  • setup.py:
    • correct website
    • supported Python versions
  • build_docs.yml
    • streamlined syntax
    • add caching
  • unittests.yml
    • add nightly cron job
    • streamlined syntax
  • upload_package.yml
    • bump actions/checkout and actions/setup-python versions

@jGaboardi jGaboardi self-assigned this Dec 30, 2020
@jGaboardi
Copy link
Member Author

@renanxcortes @knaaptime There is currently no Development Status classifier for segregation, which there are with other PySAL submodules (libpysal for example). This should be added to setup.py.

@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #160 (8943798) into master (04422ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files          65       65           
  Lines        2779     2779           
=======================================
  Hits         2383     2383           
  Misses        396      396           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04422ad...8943798. Read the comment docs.

@knaaptime
Copy link
Member

sweet, thanks for this. two questions:

  • are you sure cranking down the timeout from 90 to 20 leaves enough margin? is there a downside to the timeout being too long?
  • looks like there's no mamba specification in here, right?

@jGaboardi
Copy link
Member Author

  • are you sure cranking down the timeout from 90 to 20 leaves enough margin? is there a downside to the timeout being too long?
  • looks like there's no mamba specification in here, right?
  • Correct, no mamba here. As you mentioned before, it's not really doing anything for us yet, but shall I add it in for completeness?

@knaaptime knaaptime merged commit cc80a08 into pysal:master Dec 31, 2020
@jGaboardi jGaboardi deleted the package_maint branch December 31, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants