Skip to content

DEP: deprecate functions moved to neatnet #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinfleis
Copy link
Member

@jGaboardi what are we doing with roundabout_simplification and consolidate_intersections? If we want to keep them alive, then both should likely move to neatnet.

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.2%. Comparing base (4037c70) to head (a629d21).
Report is 109 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #696     +/-   ##
=======================================
+ Coverage   97.4%   98.2%   +0.8%     
=======================================
  Files         26      40     +14     
  Lines       4328    7158   +2830     
=======================================
+ Hits        4214    7026   +2812     
- Misses       114     132     +18     
Files with missing lines Coverage Δ
momepy/preprocessing.py 93.9% <100.0%> (+0.6%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi
Copy link
Member

@jGaboardi what are we doing with roundabout_simplification and consolidate_intersections? If we want to keep them alive, then both should likely move to neatnet.

Good question...

I think it's your call on that. What are you leaning towards?

@martinfleis
Copy link
Member Author

Never used them in any pipeline but I can imagine ppl might want to do just a subset of simplification. I am also not sure how well they work. We can postpone this decision for a next release if needed. There's no rush to remove stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants