refactor: Decouple discovery by duplicating info utils #2951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change decouples the discovery module from the main virtualenv module by duplicating utility functions from `virtualenv.info` into the `virtualenv.discovery` module. - A new `virtualenv.discovery.info` module was created with a copy of `fs_is_case_sensitive`, `fs_path_id`, and `IS_WIN`. - `virtualenv.info` is left unchanged to maintain its functionality for the core library. - The discovery-related files (`py_info.py`, `builtin.py`) now use their own private copy of these utilities from `discovery.info`. - The dependency of `cached_py_info.py` on `virtualenv.util.subprocess` was removed. This approach uses code duplication to achieve a clean separation, preparing the `discovery` module for extraction into its own package without creating a hard dependency from the core library. Signed-off-by: Emre Şafak <[email protected]>
Signed-off-by: Emre Şafak <[email protected]>
gaborbernat
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change decouples the discovery module from the main virtualenv module by duplicating utility functions from
virtualenv.infointo thevirtualenv.discoverymodule.virtualenv.discovery.infomodule was created with a copy offs_is_case_sensitive,fs_path_id, andIS_WIN.virtualenv.infois left unchanged to maintain its functionality for the core library.py_info.py,builtin.py) now use their own private copy of these utilities fromdiscovery.info.cached_py_info.pyonvirtualenv.util.subprocesswas removed.tox -e fix)docs/changelogfolder