refactor: Decouple discovery from creator plugins #2949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PythonInfo class had a method called creators() that directly imported and used CreatorSelector from virtualenv.run.plugin.creators. This created a tight coupling between the discovery and creator plugin systems. This commit removes the creators() method from PythonInfo, making it a pure data class. The logic for selecting a creator has been moved to the call sites, which now directly use CreatorSelector.for_interpreter(python_info). This change prepares the discovery code to be moved into a new, standalone package. Signed-off-by: Emre Şafak <[email protected]>
gaborbernat
requested changes
Aug 11, 2025
gaborbernat
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PythonInfo class had a method called creators() that directly imported and used CreatorSelector from
virtualenv.run.plugin.creators. This created a tight coupling between the discovery and creator plugin systems.This commit removes the creators() method from PythonInfo, making it a pure data class. The logic for selecting a creator has been moved to the call sites, which now directly use
CreatorSelector.for_interpreter(python_info).This change prepares the discovery code to be moved into a new, standalone package (#2074).
tox -e fix)docs/changelogfolder