fix(lint): Disable FIX002 to allow TODO comments #2926
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linter was configured to flag all TODO comments, which can discourage developers from leaving them. This change disables the FIX002 rule in ruff to allow TODO comments without triggering a linting error.
gaborbernat
requested changes
Aug 1, 2025
|
OK I won't leave them, but I won't open tickets for every little issue either! |
|
That's fine, if something is not important, to do it right there and is not big enough to have an issue, it's likely a case of you ain't gonna need it. People don't tend to go back and clean up all this todo comments, so hence why I think they're a bit of a noise rather than value. |
|
People don't tend to go and fix things full stop. We should only be concerned with people like me who are. I hopefully fixed a flaky test in #2923 today simply because I came across it. It was not even a TODO, let alone an issue. |
|
That's great and much appreciated. However, if you go and fix it, then there's no need for either to do or an issue.😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter was configured to flag all TODO comments, which can discourage developers from leaving them. This change disables the FIX002 rule in ruff to allow TODO comments without triggering a linting error.
tox -e fix)docs/changelogfolder