fix: Remove incorrect _restore_install_lib override (closes #2728)#5240
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
fix: Remove incorrect _restore_install_lib override (closes #2728)#5240botbikamordehai2-sketch wants to merge 1 commit into
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
Avasam
reviewed
Jun 8, 2026
Comment on lines
44
to
45
| def finalize_options(self): | ||
| install.finalize_options(self) |
Contributor
There was a problem hiding this comment.
If this override now only calls the parent, why not remove it ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In v57.1.0, the custom install command
install_with_pthoverridesinstall_libincorrectly, causing installation paths to be corrupted and leading to SSL/certificate errors during dependency resolution on Python 3.6 (especially on macOS/Windows). The_restore_install_libmethod attempts to undo a secondary effect ofextra_pathbut compares a path suffix with Python code, which never matches, thus always resettinginstall_libtoinstall_libbase.Fix
Remove the
_restore_install_libmethod and its call infinalize_options. Theextra_pathmechanism does not actually require this correction; the originalfinalize_optionsfrominstallalready handles paths correctly.Closes #2728