Warn when tool dynamic fields are not listed#5238
Open
StantonMatt wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4523.
This adds a warning for pyproject configurations where a field is configured under
tool.setuptools.dynamicbut is not listed inproject.dynamic, so the directive would otherwise be silently ignored.I kept the existing entry-points behavior intact:
tool.setuptools.dynamic.entry-pointsis still considered used whenscriptsorgui-scriptsare dynamic, since those are expanded from the entry-points file.Validation:
uv run --extra test --extra cover python -m pytest setuptools/tests/config/test_pyprojecttoml_dynamic_deps.py setuptools/tests/config/test_apply_pyprojecttoml.py::TestPresetField setuptools/tests/config/test_pyprojecttoml.py -quv run --extra check ruff check setuptools/config/pyprojecttoml.py setuptools/tests/config/test_pyprojecttoml_dynamic_deps.py setuptools/tests/config/test_pyprojecttoml.pygit diff --checkreview-fix-loopclean after fixing the entry-points review finding