Skip to content

Conversation

@pradyunsg
Copy link
Member

Mostly to make my life easier as I start spending more time in this part of the codebase.

This PR will make git blame for our documentation slightly worse, but I'd much rather spend less time figuring out what symbol I'm supposed to use for a heading in a certain file + whether I should put an empty line in certain spots.

I'm trying to write all of these things down into a "conventions" document, WIP for which is here: https://github.com/pradyunsg/pip/blob/docs/conventions/docs/html/development/conventions.rst

@pradyunsg pradyunsg added type: docs Documentation related skip news Does not need a NEWS file entry (eg: trivial changes) labels Feb 18, 2020
@pradyunsg
Copy link
Member Author

If someone could take a look at this (and the supporting draft PR, which needs more work; and is most independent of this change), that'd be great!

Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks fine to me. I haven't checked that you do use the heading markers consistently, but it's certainly more consistent than it was, and when you land the style guide we can fix any further deviations incrementally.

I really dislike the "always use lowercase for pip" convention. I'd much rather we treated pip like a conventional noun (capitalise at the start of sentences) but if consensus is against me I'll survive. And while many of the changes here are related to that rule, I'd rather we had that debate independently and not as review comments on this PR - so I'm not going to block this PR on that point, but I would suggest that we open a separate "pip branding" discussion to cover it (it might also be nice to ask for submissions for a "pip logo" as part of that conversation 🙂).

@pradyunsg
Copy link
Member Author

we open a separate "pip branding" discussion to cover it (it might also be nice to ask for submissions for a "pip logo" as part of that conversation 🙂).

Yeas. :)

@pradyunsg pradyunsg merged commit cc74940 into pypa:master Feb 19, 2020
@pradyunsg pradyunsg deleted the docs/consistent-formatting branch February 19, 2020 11:53
@uranusjr
Copy link
Member

uranusjr commented Feb 19, 2020

@pradyunsg Didn’t we discover a while ago pip somehow has a logo?

@pradyunsg
Copy link
Member Author

@uranusjr I don't recall, sorry. 🙈

@xavfernandez
Copy link
Member

xavfernandez commented Feb 26, 2020

There is this one that appears from time to time but I could not find an official source.
pip-logo

@uranusjr
Copy link
Member

Yup, that’s the one I was thinking about. The logo appears if you search for pip in Google, but I have no idea where they picked this up. Probably some tutorial invented it and people just assumed it’s correct because Google says so.

@pfmoore
Copy link
Member

pfmoore commented Feb 26, 2020

Meh, that's a bit bland IMO. I was sort of hoping someone creative could come up with something with a cartoon snake in it 🙂 🐍

A snake's head peering out of a cardboard box, for packaging Pythons? This one's grabbed from a Google search and certainly copyright, but is the sort of thing I had in mind...
Snake in a box

@hugovk
Copy link
Contributor

hugovk commented Feb 26, 2020

Reminds me a bit of Coverage.py's Sleepy snake :)

https://nedbatchelder.com/blog/201912/sleepy_snake.html

@pfmoore
Copy link
Member

pfmoore commented Feb 26, 2020

Yeah, I wonder if @nedbat's son would be willing to do a logo for us?

@pradyunsg pradyunsg mentioned this pull request Feb 26, 2020
@anudit
Copy link
Contributor

anudit commented Feb 27, 2020

Whipped up a couple of ideas. @pradyunsg @uranusjr @pfmoore


@ei8fdb
Copy link
Contributor

ei8fdb commented Mar 5, 2020

Logo

Just saw this issue. I'd like to suggest posting the request for a logo to the Open Source Design jobs board. We (Open Source Design) run a jobs board for lots of different types of design work - logo design included.

You can do it here: https://opensourcedesign.net/jobs/job-form/

The way things usually go are: an interested designer will pick up the job post. They'll have some questions about brief, etc.

I won't be doing the design work - I'm a terrible logo designer - but I'm happy to be a/the contact person for this design.

If this is a good idea, before it gets posted, I'd suggest we have a short discussion on creating a design brief. It could be a nice community activity to get inspiration from the pip (maybe wider python?) community about pip is to them.

Thoughts?

Disclosure: I'm one of the Open Source Design core members.

@pradyunsg
Copy link
Member Author

I'm gonna go ahead and eagerly lock this issue -- please comment on #7793 for pip branding things! ^>^

@pypa pypa locked as resolved and limited conversation to collaborators Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip news Does not need a NEWS file entry (eg: trivial changes) type: docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants