-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Consistent formatting across pip's documentation #7754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If someone could take a look at this (and the supporting draft PR, which needs more work; and is most independent of this change), that'd be great! |
pfmoore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks fine to me. I haven't checked that you do use the heading markers consistently, but it's certainly more consistent than it was, and when you land the style guide we can fix any further deviations incrementally.
I really dislike the "always use lowercase for pip" convention. I'd much rather we treated pip like a conventional noun (capitalise at the start of sentences) but if consensus is against me I'll survive. And while many of the changes here are related to that rule, I'd rather we had that debate independently and not as review comments on this PR - so I'm not going to block this PR on that point, but I would suggest that we open a separate "pip branding" discussion to cover it (it might also be nice to ask for submissions for a "pip logo" as part of that conversation 🙂).
Yeas. :) |
|
@pradyunsg Didn’t we discover a while ago pip somehow has a logo? |
|
@uranusjr I don't recall, sorry. 🙈 |
|
Yup, that’s the one I was thinking about. The logo appears if you search for pip in Google, but I have no idea where they picked this up. Probably some tutorial invented it and people just assumed it’s correct because Google says so. |
|
Reminds me a bit of Coverage.py's Sleepy snake :) |
|
Yeah, I wonder if @nedbat's son would be willing to do a logo for us? |
|
Whipped up a couple of ideas. @pradyunsg @uranusjr @pfmoore |
LogoJust saw this issue. I'd like to suggest posting the request for a logo to the Open Source Design jobs board. We (Open Source Design) run a jobs board for lots of different types of design work - logo design included. You can do it here: https://opensourcedesign.net/jobs/job-form/ The way things usually go are: an interested designer will pick up the job post. They'll have some questions about brief, etc. I won't be doing the design work - I'm a terrible logo designer - but I'm happy to be a/the contact person for this design. If this is a good idea, before it gets posted, I'd suggest we have a short discussion on creating a design brief. It could be a nice community activity to get inspiration from the pip (maybe wider python?) community about pip is to them. Thoughts? Disclosure: I'm one of the Open Source Design core members. |
|
I'm gonna go ahead and eagerly lock this issue -- please comment on #7793 for pip branding things! ^>^ |



Mostly to make my life easier as I start spending more time in this part of the codebase.
This PR will make
git blamefor our documentation slightly worse, but I'd much rather spend less time figuring out what symbol I'm supposed to use for a heading in a certain file + whether I should put an empty line in certain spots.I'm trying to write all of these things down into a "conventions" document, WIP for which is here: https://github.com/pradyunsg/pip/blob/docs/conventions/docs/html/development/conventions.rst