Apply ruff/bugbear rules (B) #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
B
branch
2 times, most recently
from
8b672f9 to
fc11111
Compare
uranusjr
reviewed
Mar 12, 2024
DimitriPapadopoulos
force-pushed
the
B
branch
3 times, most recently
from
757c590 to
60bb607
Compare
uranusjr
approved these changes
Mar 12, 2024
DimitriPapadopoulos
changed the title
brettcannon
approved these changes
Jul 4, 2024
Member
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
I'm fine w/ the changes if @pradyunsg is.
B904 Within an `except` clause, raise exceptions with `raise ... from err` or `raise ... from None` to distinguish them from errors in exception handling
B028 No explicit `stacklevel` keyword argument found
B018 Found useless expression. Either assign it to a variable or remove it.
Member
|
Since @pradyunsg hasn't said anything in a month I decided to go ahead and merge. Thanks, @DimitriPapadopoulos ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.astral.sh/ruff/rules/raise-without-from-inside-except/
https://docs.astral.sh/ruff/rules/useless-expression/
Also, do not ignore ruff/bugbear rule B015 and B009:
https://docs.astral.sh/ruff/rules/useless-comparison/
https://docs.astral.sh/ruff/rules/get-attr-with-constant/