Skip to content

Remove duplicate namedtuple #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 2 commits into from
Sep 23, 2022
Merged

Remove duplicate namedtuple #589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1857962
Remove duplicate `namedtuple`
layday Sep 10, 2022
a8058d1
Merge branch 'main' into rm-dupe-namedtuple
brettcannon Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packaging/requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,13 @@
# for complete details.

import urllib.parse
from collections import namedtuple
from typing import Any, List, Optional, Set

from ._parser import parse_named_requirement
from ._tokenizer import ParseExceptionError
from .markers import InvalidMarker, Marker
from .specifiers import SpecifierSet

_RequirementTuple = namedtuple(
"_RequirementTuple", ["name", "url", "extras", "specifier", "marker"]
)


class InvalidRequirement(ValueError):
"""
Expand All @@ -37,7 +32,7 @@ class Requirement:

def __init__(self, requirement_string: str) -> None:
try:
req = _RequirementTuple(*parse_named_requirement(requirement_string))
req = parse_named_requirement(requirement_string)
except ParseExceptionError as e:
raise InvalidRequirement(str(e))

Expand Down