Skip to content

Add image for musllinux_1_1#1135

Merged
mayeut merged 2 commits into
pypa:masterfrom
lkollar:musl
Sep 18, 2021
Merged

Add image for musllinux_1_1#1135
mayeut merged 2 commits into
pypa:masterfrom
lkollar:musl

Conversation

@lkollar

@lkollar lkollar commented Jul 12, 2021

Copy link
Copy Markdown
Contributor

Closes: #1134

@lkollar lkollar self-assigned this Jul 12, 2021
@lkollar lkollar force-pushed the musl branch 2 times, most recently from abec629 to 61bcb8e Compare July 15, 2021 22:06
Comment thread .github/workflows/build.yml
Comment thread docker/build_scripts/build-git.sh Outdated
Comment thread docker/build_scripts/finalize.sh Outdated
Comment thread docker/build_scripts/install-entrypoint.sh Outdated
Comment thread docker/build_scripts/install-entrypoint.sh Outdated
@mayeut

mayeut commented Jul 18, 2021

Copy link
Copy Markdown
Member

Thanks for working on this @lkollar !
It looks promising.

@lkollar lkollar marked this pull request as ready for review July 19, 2021 20:16
@lkollar lkollar force-pushed the musl branch 3 times, most recently from f628508 to b0897dd Compare July 19, 2021 22:00
@lkollar

lkollar commented Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

@mayeut this is ready. I've pushed the changes as fixups and new commits to make it easier to review.

@mayeut

mayeut commented Jul 24, 2021

Copy link
Copy Markdown
Member

@lkollar,

I reworked the way python tools are installed (auditwheel & cmake).
Can you rebase please ?
I can do it if you prefer or don't have time.
Ideally I'd like to see 2 commits overall:

  • 1st commit musllinux addition as if cmake python distribution was available
  • 2nd commit with cmake installation workaround (this will allow to revert that commit easily once cmake is available for musllinux on PyPI)

Thanks

Comment thread docker/build_scripts/update-system-packages.sh Outdated
@mayeut

mayeut commented Jul 26, 2021

Copy link
Copy Markdown
Member

The requirements-*.in files have no reason to change now.
Other than that, we need to go forward with auditwheel before this can be merged.
I published some images based on this PR in order to test auditwheel pypa/auditwheel#315 & cibuildwheel pypa/cibuildwheel#768

@lkollar

lkollar commented Jul 26, 2021

Copy link
Copy Markdown
Contributor Author

3c39866 adds the workaround for CMake. I've also added a separate commit to skip the auditwheel test on musllinux and make sure that the rest of the tests run fine. I'll try to wrap up the work on auditwheel next.

Comment thread docker/build_scripts/install-libxcrypt.sh Outdated
Comment thread docker/build_scripts/install-pypy.sh Outdated
Comment thread docker/build_scripts/install-runtime-packages.sh Outdated
Comment thread docker/build_scripts/update-system-packages.sh Outdated
@mayeut

mayeut commented Jul 26, 2021

Copy link
Copy Markdown
Member

I added some more suggestions for cases that seems really dependent on musl vs glibc rather than a specific image version.
I did not add the suggestion for the workarounds which will hopefully disappear soon.

@lkollar, can you revert to draft while waiting for an auditwheel update please ?

As I see it, auditwheel will get released before the image. This PR will then be rebased and the workaround on auditwheel dropped.

@lkollar lkollar marked this pull request as draft July 27, 2021 12:31
Comment thread docker/build_scripts/install-libxcrypt.sh Outdated
Comment thread docker/Dockerfile Outdated
@mayeut

mayeut commented Sep 18, 2021

Copy link
Copy Markdown
Member

There's an unrelated issue with arm64 builds on Travis CI. I will investigate this.

The image is based on Alpine Linux 3.12.
There are no wheels for CMake on musllinux and since it takes a long
time to build it from source, we can instead install it with the OS
package manager until wheels are available.
@mayeut mayeut marked this pull request as ready for review September 18, 2021 20:07
@mayeut mayeut merged commit f12faf3 into pypa:master Sep 18, 2021
@mayeut

mayeut commented Sep 18, 2021

Copy link
Copy Markdown
Member

We'll need to add some docs but for now, I'm merging this.
Thanks @lkollar, @liath

@alex

alex commented Sep 18, 2021

Copy link
Copy Markdown
Member

🎉 are there any steps required before the images are uploaded to quay.io?

@mayeut

mayeut commented Sep 18, 2021

Copy link
Copy Markdown
Member

@alex,

once the CI build is finished on master, images should be available on quay.io
There's already an issue with the i686 image (random network failure). I'll restart the build once everything else is built (I hope I setup quay.io properly otherwise I'll have to redo that).

@alex

alex commented Sep 18, 2021 via email

Copy link
Copy Markdown
Member

@hugovk

hugovk commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Thanks for this!

Should musllinux_1_1 also be documented in the README?

@mayeut

mayeut commented Sep 20, 2021

Copy link
Copy Markdown
Member

@hugovk, yes, c.f. #1135 (comment)

elif [ "${AUDITWHEEL_POLICY}" == "manylinux_2_24" ]; then
MANYLINUX_DEPS="libc6-dev libstdc++-6-dev libglib2.0-dev libx11-dev libxext-dev libxrender-dev libgl1-mesa-dev libice-dev libsm-dev"
elif [ "${AUDITWHEEL_POLICY}" == "musllinux_1_1" ]; then
MANYLINUX_DEPS="musl-dev libstdc++ glib-dev libx11-dev libxext-dev libxrender-dev mesa-dev libice-dev libsm-dev"

This comment was marked as resolved.

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create musllinux images

6 participants