馃拝 Bundle attestation existence check together - #315
Merged
webknjaz merged 1 commit intoDec 10, 2024
Conversation
This patch moves said check out of the signing loop and performs the check early in the process. It is then able to report multiple problems in a single error.
Member
Author
|
@woodruffw does this seem reasonable? We can then make it a conditional warning in the same place in a follow-up, and it wouldn't spam people with many warnings. |
Member
Yeah, seems reasonable to me 馃檪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch moves said check out of the signing loop and performs the check early in the process. It is then able to report multiple problems in a single error.