action: enable attestations by default - #277
Merged
Merged
Conversation
Signed-off-by: William Woodruff <william@trailofbits.com>
25 tasks
Member
|
@woodruffw I just realized that the README section needs to be updated with this. |
Member
Author
Ah yep, thanks for catching that. I'll update first thing tomorrow (since this PR is from a fork on an SSO'd org...) |
Member
|
I've already merged it locally and will push soon. So I'll just add a commit on top to have something at the time of cutting the release. You can then refine it further in a follow-up. |
webknjaz
added a commit
that referenced
this pull request
Oct 30, 2024
This makes minimum modifications to indicate that `attestations` is not on by default.
Member
|
@woodruffw so did you have a chance to review fb13cb3? |
Member
Author
Sorry, forgot to respond! Yes, that change looks great to me 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attestations have been live and stable on PyPI and TestPyPI for a few weeks now, so I think we're good to flip the default here 🙂