Restore public symbols missing after compilers move #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
add-back-compiler.compiler_class
branch
from
dd24ead to
17854a1
Compare
Member
|
Thanks for this contrib. I don't see where the need for |
Contributor
Author
|
I simply restored the names that were public in the modules. If you only wanna add |
Member
Okay. Yeah, let's remove it. Thanks! |
jaraco
reviewed
Mar 17, 2025
Avasam
force-pushed
the
add-back-compiler.compiler_class
branch
from
17854a1 to
408274b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #336 and closes pypa/setuptools#4876
distutils.ccompiler.compiler_classfor backwards compatibilitymsvcsymbol whenfrom distutils._msvccompiler import *