Skip to content

Conversation

radarhere
Copy link
Contributor

@radarhere radarhere commented Jun 24, 2025

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mayeut
Copy link
Member

mayeut commented Jun 28, 2025

It seems to be missing tests as all iOS tests are forcing cp313 only for now. test_ios_platforms should probably not enforce cp313 but rely on defaults and thus allow cp314 to be tested.

@radarhere
Copy link
Contributor Author

Ok, I've pushed a commit for that.

@henryiii
Copy link
Contributor

Can't check at the moment, but isn't there a table somewhere this should be added to?

@radarhere
Copy link
Contributor Author

The table at https://github.com/pypa/cibuildwheel?tab=readme-ov-file#what-does-it-do already lists it - I think #2390 just presumed it would be automatically added.

@joerick
Copy link
Contributor

joerick commented Jun 30, 2025

You're right @henryiii - the options.md table was missing. I've added that.

@henryiii henryiii merged commit 9200810 into pypa:main Jun 30, 2025
28 checks passed
@radarhere radarhere deleted the ios branch July 26, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants