Skip to content

Conversation

@mayeut
Copy link
Member

@mayeut mayeut commented Sep 15, 2024

Revert to using cat/tar to copy files/folders into the container.

Alternative to #2006
Fix #2004

Based on #2005

@joerick
Copy link
Contributor

joerick commented Sep 16, 2024

i'll rebase this on main, now that #2005 is in

Revert to using `cat`/`tar` to copy files/folders into the container.
@henryiii
Copy link
Contributor

Why still draft? Is there something left?

@joerick
Copy link
Contributor

joerick commented Sep 16, 2024

I don't think so. I suspect it was set to draft while we were deciding between this and #2006 .

@joerick joerick marked this pull request as ready for review September 16, 2024 18:06
@henryiii
Copy link
Contributor

Ah, okay

@joerick
Copy link
Contributor

joerick commented Sep 16, 2024

Thanks for the RtD fix - looks like my rebase missed it by seconds! nvm, we can ignore that failure.

@joerick joerick merged commit 8c42e79 into pypa:main Sep 16, 2024
@mayeut mayeut deleted the use-tar branch September 17, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File ownership not preserved when copying the project inside the container

3 participants