Skip to content

git: unignore src/build in case user ignores build #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Sep 28, 2022

After checking out this project, I found that files in src/build weren't being tracked and that src appeared empty in my editor. Turns out, I used a common pattern of ignoring build in my global gitignore (which I manage centrally rather than copying and mutating boilerplate across hundreds of projects).

This change ensures that if the user has ignored build, the src/build folder won't be ignored in this project.

Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good idea.

FYI, I try to ignore such global ignores because it causes individual projects to have incomplete ignores, which hurts users who don't have the global setup. (I do have a few things, like .DSStore, but try to keep it limited).

Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks!

@FFY00 FFY00 changed the title Unignore src/build in case user ignores build. git: unignore src/build in case user ignores build Sep 28, 2022
@FFY00 FFY00 enabled auto-merge (squash) September 28, 2022 15:48
@FFY00 FFY00 merged commit e0b103c into main Sep 28, 2022
@FFY00 FFY00 deleted the unignore-src branch September 28, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants