Skip to content

Conversation

@Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Feb 19, 2025

@EveCharbie is that clearer ?


This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (bbc656f) to head (e156a90).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   77.69%   77.75%   +0.05%     
==========================================
  Files         156      156              
  Lines       18005    18036      +31     
==========================================
+ Hits        13989    14023      +34     
+ Misses       4016     4013       -3     
Flag Coverage Δ
unittests 77.75% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EveCharbie
EveCharbie previously approved these changes Feb 20, 2025
Copy link
Collaborator

@EveCharbie EveCharbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you are done (either accept or decline my recommendations), you can auto-merge this PR ;)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)

@pariterre pariterre merged commit 793bdd3 into master Feb 24, 2025
23 of 24 checks passed
@pariterre pariterre deleted the Ipuch-patch-2 branch February 24, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants