Skip to content

Conversation

@EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Feb 18, 2025

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (c194ef1) to head (bbc656f).
Report is 199 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
- Coverage   77.70%   77.69%   -0.01%     
==========================================
  Files         156      156              
  Lines       18011    18005       -6     
==========================================
- Hits        13995    13989       -6     
  Misses       4016     4016              
Flag Coverage Δ
unittests 77.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EveCharbie EveCharbie changed the title [WIP] Fixing some TODOs [RTR] Fixing some TODOs Feb 18, 2025
@EveCharbie
Copy link
Collaborator Author

@Ipuch could you review this please ? :)

@Ipuch Ipuch self-requested a review February 18, 2025 14:45
Copy link
Collaborator

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@Ipuch Ipuch merged commit 2abb6b4 into pyomeca:master Feb 18, 2025
24 checks passed
@EveCharbie EveCharbie deleted the fixing_some_TODOs branch March 13, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants