Skip to content

Conversation

@EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Feb 8, 2024

This change is Reviewable

@EveCharbie EveCharbie changed the title SOCP collocation scaling [RTR] SOCP collocation scaling Feb 8, 2024
pariterre
pariterre previously approved these changes Feb 8, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre changed the title [RTR] SOCP collocation scaling SOCP collocation scaling Feb 8, 2024
@codecov
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c02d206) 78.39% compared to head (2d3e4cc) 78.39%.
Report is 1 commits behind head on master.

Files Patch % Lines
bioptim/limits/constraints.py 0.00% 4 Missing ⚠️
bioptim/limits/penalty.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   78.39%   78.39%           
=======================================
  Files         140      140           
  Lines       16081    16081           
=======================================
  Hits        12607    12607           
  Misses       3474     3474           
Flag Coverage Δ
unittests 78.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EveCharbie
Copy link
Collaborator Author

@pariterre the codecov will be fixed after your PR on time where I will implement a complex example covering "all" the important stochastic features.

@EveCharbie EveCharbie changed the title SOCP collocation scaling [RTM?] SOCP collocation scaling Feb 9, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit 7493b6a into pyomeca:master Feb 9, 2024
@EveCharbie EveCharbie deleted the variable_noise_SOCP branch March 1, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants