Skip to content

Conversation

@pariterre
Copy link
Member

@pariterre pariterre commented Jan 11, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 443 lines in your changes are missing coverage. Please review.

Comparison is base (f8e7be4) 78.17% compared to head (0a6c34e) 78.72%.
Report is 225 commits behind head on master.

Files Patch % Lines
bioptim/optimization/solution/solution.py 81.78% 53 Missing ⚠️
bioptim/limits/multinode_penalty.py 36.06% 39 Missing ⚠️
bioptim/limits/penalty_option.py 86.63% 33 Missing ⚠️
bioptim/limits/constraints.py 18.42% 31 Missing ⚠️
bioptim/gui/check_conditioning.py 66.66% 25 Missing ⚠️
bioptim/dynamics/ode_solver.py 86.70% 23 Missing ⚠️
bioptim/optimization/solution/solution_data.py 84.34% 18 Missing ⚠️
...optimization/stochastic_optimal_control_program.py 10.00% 18 Missing ⚠️
bioptim/limits/penalty.py 37.50% 15 Missing ⚠️
...im/examples/holonomic_constraints/two_pendulums.py 0.00% 12 Missing ⚠️
... and 42 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
+ Coverage   78.17%   78.72%   +0.55%     
==========================================
  Files         138      139       +1     
  Lines       16077    15709     -368     
==========================================
- Hits        12568    12367     -201     
+ Misses       3509     3342     -167     
Flag Coverage Δ
unittests 78.72% <81.29%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pariterre pariterre merged commit 17e3628 into pyomeca:master Jan 11, 2024
@pariterre pariterre mentioned this pull request Jan 11, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant