Skip to content

Conversation

@Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Nov 8, 2023

This change is Reviewable

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Ipuch)


bioptim/.codeclimate.yml line 5 at r1 (raw file):

  argument-count:
    config:
      threshold: 4

6


bioptim/.codeclimate.yml line 11 at r1 (raw file):

  file-lines:
    config:
      threshold: 250

500


bioptim/.codeclimate.yml line 17 at r1 (raw file):

  method-count:
    config:
      threshold: 20

40


bioptim/.codeclimate.yml line 20 at r1 (raw file):

  method-lines:
    config:
      threshold: 25

40

@pariterre pariterre changed the title yml code climate [RTM when pushed] yml code climate Nov 8, 2023
@pariterre pariterre changed the title [RTM when pushed] yml code climate yml code climate Nov 8, 2023
Copy link
Collaborator Author

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @pariterre)


bioptim/.codeclimate.yml line 5 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

6

Done.


bioptim/.codeclimate.yml line 11 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

500

Done.


bioptim/.codeclimate.yml line 17 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

40

Done.


bioptim/.codeclimate.yml line 20 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

40

Done.

@Ipuch Ipuch changed the title yml code climate [RTM] yml code climate Nov 20, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre merged commit 1030ae7 into pyomeca:master Jan 8, 2024
@Ipuch Ipuch deleted the ymlclimate branch March 31, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants