-
Notifications
You must be signed in to change notification settings - Fork 55
[RTM] Variational integrator #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #696 +/- ##
==========================================
- Coverage 81.82% 81.64% -0.18%
==========================================
Files 112 117 +5
Lines 12919 13300 +381
==========================================
+ Hits 10571 10859 +288
- Misses 2348 2441 +93
☔ View full report in Codecov by Sentry. |
pariterre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @20chupin)
tests/test_variational_integrator_examples.py line 10 at r2 (raw file):
def test_variational_pendulum():
Please add the use_sx = True and false in the configuration
tests/test_variational_integrator_examples.py line 75 at r2 (raw file):
def test_variational_pendulum_with_holonomic_constraints():
Please add the use_sx = True and false in the configuration
20chupin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 8 of 9 files reviewed, 2 unresolved discussions (waiting on @pariterre)
tests/test_variational_integrator_examples.py line 10 at r2 (raw file):
Previously, pariterre (Pariterre) wrote…
Please add the use_sx = True and false in the configuration
Done.
tests/test_variational_integrator_examples.py line 75 at r2 (raw file):
Previously, pariterre (Pariterre) wrote…
Please add the use_sx = True and false in the configuration
Done.
pariterre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @20chupin)
|
GG @20chupin ! |
This change is