Skip to content

Conversation

@20chupin
Copy link
Contributor

@20chupin 20chupin commented Jun 13, 2023

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 73.27% and project coverage change: -0.18 ⚠️

Comparison is base (2cce426) 81.82% compared to head (f1b68ec) 81.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
- Coverage   81.82%   81.64%   -0.18%     
==========================================
  Files         112      117       +5     
  Lines       12919    13300     +381     
==========================================
+ Hits        10571    10859     +288     
- Misses       2348     2441      +93     
Impacted Files Coverage Δ
...nics_and_optimal_control/biorbd_model_holonomic.py 56.81% <56.81%> (ø)
...control/example_variational_integrator_pendulum.py 70.27% <70.27%> (ø)
..._integrator_with_holonomic_constraints_pendulum.py 71.79% <71.79%> (ø)
...mal_control/variational_optimal_control_program.py 90.74% <90.74%> (ø)
...es/discrete_mechanics_and_optimal_control/enums.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@20chupin 20chupin changed the title [RTR] Variational integrator to merge when the discussions are accepted on the other PR [RTM] Variational integrator to merge when the discussions are accepted on the other PR Jun 15, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @20chupin)


tests/test_variational_integrator_examples.py line 10 at r2 (raw file):

def test_variational_pendulum():

Please add the use_sx = True and false in the configuration


tests/test_variational_integrator_examples.py line 75 at r2 (raw file):

def test_variational_pendulum_with_holonomic_constraints():

Please add the use_sx = True and false in the configuration

Copy link
Contributor Author

@20chupin 20chupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 8 of 9 files reviewed, 2 unresolved discussions (waiting on @pariterre)


tests/test_variational_integrator_examples.py line 10 at r2 (raw file):

Previously, pariterre (Pariterre) wrote…

Please add the use_sx = True and false in the configuration

Done.


tests/test_variational_integrator_examples.py line 75 at r2 (raw file):

Previously, pariterre (Pariterre) wrote…

Please add the use_sx = True and false in the configuration

Done.

@20chupin 20chupin changed the title [RTM] Variational integrator to merge when the discussions are accepted on the other PR [RTM] Variational integrator Jun 19, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @20chupin)

@pariterre pariterre merged commit b5e6920 into pyomeca:master Jun 19, 2023
@pariterre
Copy link
Member

GG @20chupin !

@20chupin 20chupin deleted the var_int_without_files branch June 19, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants