Skip to content

Conversation

@AntoineLeroy
Copy link
Contributor

@AntoineLeroy AntoineLeroy commented Feb 16, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 81.67% // Head: 81.67% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (c3e03b2) compared to base (91ace20).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   81.67%   81.67%   -0.01%     
==========================================
  Files         106      106              
  Lines       11805    11804       -1     
==========================================
- Hits         9642     9641       -1     
  Misses       2163     2163              
Impacted Files Coverage Δ
...xamples/getting_started/example_external_forces.py 87.87% <100.00%> (ø)
bioptim/optimization/optimal_control_program.py 87.13% <100.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ipuch
Copy link
Collaborator

Ipuch commented Feb 17, 2023

@pariterre we forgot to accept this. To clarify this was made to prevent an error due to size of initial guesses that was not raised anymore in init stuff because of the scaling PR. We moved a block to reoder this.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AntoineLeroy)

@pariterre pariterre merged commit 31f30e4 into pyomeca:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants