Skip to content

Conversation

@EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Nov 2, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @EveCharbie)


bioptim/examples/getting_started/custom_initial_guess.py line 20 at r3 (raw file):

import numpy as np
import biorbd_casadi as biorbd
from bioptim.misc.enums import MagnitudeType

This seems related to @rapidnico PR. But it should not appear here. I actually specifically asked in the other PR to change this... If your PR are related, merge your work in a single PR, otherwise I am bound to repeat myself not knowing who is responsible for the changes


bioptim/limits/path_conditions.py line 1150 at r3 (raw file):

            raise ValueError("bounds must be specified to generate noised initial guess")

        if len(bounds) != nb_phases:

I assume all these changes are not yours?

Code quote:

    @staticmethod
    def _check_type_and_format_bounds(bounds, nb_phases):
        """
        Check bounds type and format

        Parameters
        ----------
        nb_phases
            The number of phases
        """
        if bounds is None:
            raise ValueError("bounds must be specified to generate noised initial guess")

        if len(bounds) != nb_phases:
            raise ValueError(f"Invalid size of 'bounds', 'bounds' must be size {nb_phases}")

        return bounds

tests/test_update_bounds_and_init.py line 5 at r3 (raw file):

import biorbd_casadi as biorbd
from casadi import MX
from bioptim.misc.enums import MagnitudeType

This should not appear as is, as specified in the @rapidnico PR

Copy link
Collaborator Author

@EveCharbie EveCharbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was not RTR. Yes I merged Rapidnico's branch into mine in the mean time. But I will surely wait until his PR is accepted before asking you to review ;)

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @EveCharbie)

pariterre
pariterre previously approved these changes Nov 3, 2022
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@EveCharbie EveCharbie changed the title multi-start values testing [RTR] multi-start values testing Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 80.53% // Head: 80.53% // No change to project coverage 👍

Coverage data is based on head (ed66775) compared to base (8fbd14e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #570   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files          95       95           
  Lines       10498    10498           
=======================================
  Hits         8455     8455           
  Misses       2043     2043           
Impacted Files Coverage Δ
...tim/examples/getting_started/example_multistart.py 26.47% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre
Copy link
Member

@EveCharbie RTM?

@pariterre pariterre changed the title [RTR] multi-start values testing [RTM] multi-start values testing Nov 10, 2022
@EveCharbie
Copy link
Collaborator Author

@pariterre yep :)

@pariterre pariterre merged commit 5eff5d0 into pyomeca:master Nov 10, 2022
@EveCharbie EveCharbie deleted the Multi-start_test branch May 30, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants