-
Notifications
You must be signed in to change notification settings - Fork 55
[RTM] Moving examples #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTM] Moving examples #1023
Conversation
Ipuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ipuch reviewed 96 of 229 files at r1, 145 of 145 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)
bioptim/examples/getting_started/custom_phase_transitions.py line 209 at r2 (raw file):
def main(): biorbd_model_path = ExampleUtils.examples_folder() + "/models/cube.bioMod"
.folder
Code quote:
examples_folder()
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
- Coverage 78.62% 77.37% -1.26%
==========================================
Files 159 182 +23
Lines 18608 20186 +1578
==========================================
+ Hits 14631 15618 +987
- Misses 3977 4568 +591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pariterre or @Ipuch all tests have passed, I think this could be merged :) |
EveCharbie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 98 of 241 files reviewed, 1 unresolved discussion (waiting on @Ipuch)
bioptim/examples/getting_started/custom_phase_transitions.py line 209 at r2 (raw file):
Previously, Ipuch (Pierre Puchaud) wrote…
.folder
Done.
We displaced all
If you are getting started with
bioptim, you should have a look at the folder getting_started, where you will find examples to show you the fundamentals of building an Optimal Control Problem withbioptim.The first examples you should have a look are:
This change is