Skip to content

Conversation

@EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Sep 12, 2025

In the continuity of PR #998


This change is Reviewable

@EveCharbie EveCharbie changed the title Implemented ConstraintWeight [WIP] Implemented ConstraintWeight Sep 12, 2025
@EveCharbie EveCharbie changed the title [WIP] Implemented ConstraintWeight [RTR] Implemented ConstraintWeight Sep 15, 2025
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pariterre reviewed 2 of 5 files at r1, 5 of 7 files at r3, 1 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)


bioptim/examples/getting_started/custom_constraint_weights.py line 3 at r5 (raw file):

"""
This example is a trivial box sent upward. It is designed to investigate the different types of constraint weights one
can define in bioptim. Therefore, it shows how one can define the weight of the control constraint.

Add what it means to change the constraint weightings (tolerance)

@pariterre pariterre changed the title [RTR] Implemented ConstraintWeight [RTM when answered] Implemented ConstraintWeight Sep 15, 2025
@EveCharbie
Copy link
Collaborator Author

@pariterre ready to merge :)
Feels so good to see the acados tests passing ;) Cannot wait to see that green check next to PRs again !

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!!
:lgtm:

@pariterre reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit fe538c9 into pyomeca:master Sep 16, 2025
21 of 22 checks passed
@EveCharbie EveCharbie deleted the ConstraintWeight branch September 29, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants