Add Type XRefs to IR #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
type-xrefs1
branch
2 times, most recently
from
c3151c0 to
b197dfb
Compare
This updates the IR representation of types to a possible list of strings or xref objects. The xrefs can be internal xrefs to types in the project or external ones to types defined in dependencies. I don't currently add xrefs to intrinsic types but that would be a natural thing to do. The renderer currently throws this information away. Rendering it is left to a followup.
hoodmane
force-pushed
the
type-xrefs1
branch
from
b197dfb to
a86e6c4
Compare
Merged
hoodmane
added a commit
that referenced
this pull request
Sep 24, 2023
This is the second half of #51. It adds support to the renderer to generate internal xrefs. Which wasn't that much work. In a followup it would be nice to add external xrefs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the IR representation of types to a possible list of strings or xref objects. The xrefs can be internal xrefs to types in the project or external ones to types defined in dependencies. I don't currently add xrefs to intrinsic types but that would be a natural thing to do.
The renderer currently throws this information away. Rendering it is left to a followup.