Skip to content

Update platform name to pyemscripten - #319

Merged
ryanking13 merged 9 commits into
pyodide:mainfrom
ryanking13:pyemscripten-platform
Apr 2, 2026
Merged

Update platform name to pyemscripten#319
ryanking13 merged 9 commits into
pyodide:mainfrom
ryanking13:pyemscripten-platform

Conversation

@ryanking13

@ryanking13 ryanking13 commented Mar 30, 2026

Copy link
Copy Markdown
Member
  • Changelog

@agriyakhetarpal agriyakhetarpal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ryanking13! One typo (suggestion inlined below).

Also, one question: do we estimate a use for this legacy environment variable? Should we rather wait a bit before merging/releasing, until formal approval of the PEP, so we don't pull these changes into cibuildwheel and other users right away? It will make my job a bit easier :)

Comment thread pyodide_build/build_env.py Outdated
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
@ryanking13

Copy link
Copy Markdown
Member Author

do we estimate a use for this legacy environment variable?

I am not very sure, but there might be people using old Pyodide runtime and making their own distribution with custom wheels (maybe @pepijndevos or @juntyr?) I don't want them to block updating pyodide-build version because of this.

Should we rather wait a bit before merging/releasing, until formal approval of the PEP, so we don't pull these changes into cibuildwheel and other users right away? It will make my job a bit easier :)

Yeah, even after merging this, we can delay the release until PEP 783 gets accepted.

@ryanking13 ryanking13 added the integration This PR will run the integration tests. This label can be used as a persistent marker to do so. label Apr 1, 2026
@agriyakhetarpal

Copy link
Copy Markdown
Member

Sounds good to me!

@juntyr

juntyr commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

I still build my distribution in-tree inside the Pyodide Docker container using synchronised pyodide, pyodide-build, and pyodide-recipes repos. So I will likely only experience this change once the new platform name is adopted across all three repositories (and Pyodide v0.30 is released and I upgrade to that). Still, I appreciate having the environment variable (maybe for a release or two) since I sometimes pull in newer recipes that require newer versions of pyodide-build.

TLDR: sounds good to me!

Comment thread CHANGELOG.md
Comment on lines +10 to +15
### Changed

- Platform name for the Pyodide wheel is now `pyemscripten` instead of `pyodide`, following the PEP 783 standard.
If you want to use the old platform name, you can set the `USE_LEGACY_PLATFORM` environment variable to `1`.
[#319](https://github.com/pyodide/pyodide-build/pull/319)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would something like this work?

Suggested change
### Changed
- Platform name for the Pyodide wheel is now `pyemscripten` instead of `pyodide`, following the PEP 783 standard.
If you want to use the old platform name, you can set the `USE_LEGACY_PLATFORM` environment variable to `1`.
[#319](https://github.com/pyodide/pyodide-build/pull/319)
### Changed
- Platform name for the Pyodide wheel is now `pyemscripten` instead of `pyodide`, following the PEP 783 standard.
If you want to use the old platform name, you can set the `USE_LEGACY_PLATFORM` environment variable to `1`. This environment variable will be available until Pyodide v0.31, and will be removed in v0.32.
[#319](https://github.com/pyodide/pyodide-build/pull/319)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the pyemscripten platform has almost nothing to do with pyodide runtime itself. It only affects how packages are installed, and Pyodide does not check the platform name at all. It is only the pyodide venv (pyodide-build) or micropip that checks the platform. So I think it is weird to say that it will be removed in future Pyodide versions.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting. Thanks for the clarification!

@ryanking13
ryanking13 merged commit c6fcf2c into pyodide:main Apr 2, 2026
22 checks passed
@agriyakhetarpal

Copy link
Copy Markdown
Member

I was drafting a release just now, but I remembered that we merged this PR. Should we wait for a bit, @ryanking13, or this safe to release for usage downstream?

@ryanking13

ryanking13 commented Apr 3, 2026

Copy link
Copy Markdown
Member Author

@agriyakhetarpal

Oh yeah. Hmm, I am +1 for just making a release. I don't think that the platform name will be changed again. If that happens, let's just yank that version and release a new version.

@agriyakhetarpal

Copy link
Copy Markdown
Member

Done, I'll create a new release after merging a PR for #324. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration This PR will run the integration tests. This label can be used as a persistent marker to do so.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants