Fix micropip.install to search shared libraries inside the wheel correctly - #97
Merged
Merged
Conversation
hoodmane
approved these changes
Jan 29, 2024
Member
There was a problem hiding this comment.
Thanks @ryanking13! Could you add a changelog entry?
| url = self._register_handler(path) | ||
|
|
||
| if name in self._wheels and not replace: | ||
| return |
Member
There was a problem hiding this comment.
Maybe we should raise here? I think silently doing nothing is likely to be confusing.
Member
Author
There was a problem hiding this comment.
I used this method to register all the wheels included in the Pyodide distribution as test wheels, as without this, they would conflict with pytest wheel, etc that I put in for testing.
I think it will be fine as long as we know what we are doing. I added some comments about it.
Member
Author
|
Oh, I forgot to update the changelog... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, micropip was not able to locate shared libraries in the
.libsdirectory of the wheel.For instance, in Pyodide 0.25.0,
works, while
does not work.
This is because
micropip.installdoes not search the path thatpyodide.loadPackagelooks for.This PR fixes it by using the same API
pyodide.loadPackageis using when loading shared libraries.