Skip to content

Change package query order when custom index URLs are given - #83

Merged
ryanking13 merged 14 commits into
pyodide:mainfrom
ryanking13:index-url-priority
Sep 19, 2023
Merged

Change package query order when custom index URLs are given#83
ryanking13 merged 14 commits into
pyodide:mainfrom
ryanking13:index-url-priority

Conversation

@ryanking13

Copy link
Copy Markdown
Member

Resolve #80

This PR changes the query order of micropip.

  1. If index_urls is not given

Look for pyodide-lock.json first, then query PyPI.

  1. If index_urls is given

Query index URLs first, then look for pyodide-lock.json.

@ryanking13 ryanking13 changed the title Fix package query order when custom index URLs are given Change package query order when custom index URLs are given Sep 11, 2023

@rth rth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryanking13! This is indeed very useful.

Comment thread CHANGELOG.md Outdated

## Unreleased

## [0.4.1] - 2023/09/XX

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it a 0.5.0 as its not really a bug fix, but rather a behavior change.

@ryanking13
ryanking13 merged commit b607b06 into pyodide:main Sep 19, 2023
@ryanking13
ryanking13 deleted the index-url-priority branch September 19, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

My attempt to use index_urls for installing a scikit-learn wheel from pypi.anaconda.org

2 participants