Skip to content

Handle urls with search params #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rth merged 4 commits into from
Dec 12, 2022
Merged

Handle urls with search params #33

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fb0d57
Handle urls with search params
hoodmane Dec 9, 2022
b85d637
Merge remote-tracking branch 'upstream/main' into url-search-params
rth Dec 10, 2022
42fef26
Merge remote-tracking branch 'upstream/main' into url-search-params
rth Dec 12, 2022
c116617
Add changelog and test
rth Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion micropip/_micropip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ async def add_requirement(self, req: str | Requirement) -> None:
if isinstance(req, Requirement):
return await self.add_requirement_inner(req)

if not req.endswith(".whl"):
if not urlparse(req).path.endswith(".whl"):
return await self.add_requirement_inner(Requirement(req))

# custom download location
Expand Down